Skip to content

[crater] Add impl From<f16> for f32 #142723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[crater] Add impl From<f16> for f32 #142723

wants to merge 1 commit into from
+1 −11

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Jun 19, 2025 •
edited by rustbot
Loading

Crater run to see what the effects of adding impl From<f16> for f32 without changing the fallback (a.k.a. things that would be caught by the FCW in #139087). This needs a @craterbot check.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 19, 2025
@beetrees beetrees mentioned this pull request Jun 19, 2025
Open
@traviscross
Copy link
Contributor

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 19, 2025

⌛ Trying commit e4ad46e with merge 8d46be7…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 19, 2025
@rust-bors
Auto merge of #142723 - beetrees:crater-impl-from-f16-for-f32, r=<try>
8d46be7 
[crater] Add `impl From<f16> for f32`

Crater run to see what the effects of adding `impl From<f16> for f32` without changing the fallback (a.k.a. things that would be caught by the FCW in #139087). This needs a ``@craterbot` check`.
@rust-bors
Copy link

rust-bors bot commented Jun 19, 2025

☀️ Try build successful (CI)
Build commit: 8d46be7 (8d46be77cd48fdbcced888d027457e2c9cf2aa16, parent: 2fcf1776b9ccef89993dfe40e9f5c4908e2d2d48)

@tgross35
Copy link
Contributor

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-142723 created and queued.
🤖 Automatically detected try build 8d46be7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 19, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-142723 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-142723 is completed!
📊 3143 regressed and 10 fixed (650587 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 22, 2025
@traviscross
Copy link
Contributor

Various versions of epaint, glyph_brush, and taffy seem to account for the vast majority of the breakage. Whatever else we do, it'd probably be worth putting in PRs for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beetrees @traviscross @tgross35 @craterbot @rustbot